No need to explicitly delete the pre-existsing histogram for ROOT >= 6.38 #49319

smuzaffar · 2025-11-05T10:57:55Z

Fixes #49309
This change needs a newer ROOT 6.38
With latest root change root-project/root@17a49d1 , to avoid memory leak, SetHistogram now deletes pre-existing histogram. This change propose to call runGraph->GetHistogram()->Delete(); only for old versions of root.

cmsbuild · 2025-11-05T10:58:21Z

cms-bot internal usage

cmsbuild · 2025-11-05T11:00:24Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-49319/46683

cmsbuild · 2025-11-05T11:00:49Z

A new Pull Request was created by @smuzaffar for master.

It involves the following packages:

Alignment/OfflineValidation (alca)

@arunhep, @atpathak, @cmsbuild, @perrotta can you please review it and eventually sign? Thanks.
@mmusich, @rsreds, @tlampen, @tocheng, @yuanchao this is something you requested to watch as well.
@ftenchini, @mandrenguyen, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

smuzaffar · 2025-11-05T11:03:21Z

please test

it should work for existsing root version of default IBs

perrotta · 2025-11-05T11:08:48Z

Alignment/OfflineValidation/bin/jetHtPlotter.cc

  }  // Loop over all runs in original histogram

  // Delete remaining old content and replace it with new one calculated from luminosities
+#if ROOT_VERSION_CODE < ROOT_VERSION(6, 39, 1)


Isn't the fix applied since root version 6.38.00?

TGraph::SetHistogram() can leak memory root-project/root#20252

root-project/root@17a49d1

thanks @perrotta , yes it is applied for root 6.38.00 .

cmsbuild · 2025-11-05T11:49:23Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-49319/46686

cmsbuild · 2025-11-05T11:49:46Z

Pull request #49319 was updated. @arunhep, @atpathak, @cmsbuild, @perrotta can you please check and sign again.

smuzaffar · 2025-11-05T11:50:08Z

please test

cmsbuild · 2025-11-05T13:41:20Z

+1

Size: This PR adds an extra 32KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8ad1e7/49268/summary.html
COMMIT: c40a569
CMSSW: CMSSW_16_0_X_2025-11-04-2300/el8_amd64_gcc13
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/49319/49268/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

You potentially added 5 lines to the logs
Reco comparison results: 6 differences found in the comparisons
DQMHistoTests: Total files compared: 51
DQMHistoTests: Total histograms compared: 3939953
DQMHistoTests: Total failures: 85
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3939848
DQMHistoTests: Total skipped: 20
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 50 files compared)
Checked 218 log files, 188 edm output root files, 51 DQM output files
TriggerResults: no differences found

smuzaffar · 2025-11-07T09:58:46Z

@cms-sw/alca-l2 , can you please review this change?

perrotta · 2025-11-07T10:34:57Z

@cms-sw/alca-l2 , can you please review this change?

@smuzaffar I am perfectly fine with this fix,
I was waiting for it being tested in the relevant IBs, supposedly with cms-sw/cmsdist#10176 : shouldn't I wait for the tests of that cmsdist PR to succeed before signing? (I tested this fix directly in root without this PR, and it works: if you want to have it merged since now, I could rely on that side validation to sign it)

perrotta · 2025-11-08T08:32:15Z

+alca

As far as I can see from the results of the latest tests in [ROOT6] Updated root to tip of branch master and used newer 6.39.1 version cmsdist#10176 (comment), while other problems persist with the move to root 6.39.1, the particolar one addressed here gets fixed by this PR. It can therefore get merged since now in the master branch of the release.

cmsbuild · 2025-11-08T08:32:40Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @mandrenguyen, @ftenchini (and backports should be raised in the release meeting by the corresponding L2)

mandrenguyen · 2025-11-08T15:53:13Z

+1

iarspider · 2025-11-10T11:26:28Z

Hi @smuzaffar ,

the test still failed in CMSSW_16_0_ROOT6_X_2025-11-09-2300 that has this PR. I think we also shouldn't do runGraph->SetHistogram(nullptr); with new ROOT?

smuzaffar · 2025-11-10T12:48:46Z

@iarspider , do we have root >= 6.38 in root6 ibs? If not then test will keep on failing

cmsbuild added this to the CMSSW_16_0_X milestone Nov 5, 2025

cmsbuild added alca-pending pending-signatures tests-pending orp-pending code-checks-pending trk labels Nov 5, 2025

cmsbuild added code-checks-approved and removed code-checks-pending labels Nov 5, 2025

smuzaffar mentioned this pull request Nov 5, 2025

[ROOT6_X] JetHTall unit test failing after ROOT update. #49309

Closed

cmsbuild added tests-started and removed tests-pending labels Nov 5, 2025

smuzaffar mentioned this pull request Nov 5, 2025

[ROOT6] Updated root to tip of branch master and used newer 6.39.1 version cms-sw/cmsdist#10176

Closed

perrotta reviewed Nov 5, 2025

View reviewed changes

No need to explicitly delete the pre-existsing histogram for ROOT 6.38

c40a569

smuzaffar force-pushed the fix-root639-histogram-delete branch from bfa0a8f to c40a569 Compare November 5, 2025 11:16

cmsbuild added tests-pending code-checks-pending and removed tests-started code-checks-approved labels Nov 5, 2025

cmsbuild added code-checks-approved and removed code-checks-pending labels Nov 5, 2025

cmsbuild removed the tests-pending label Nov 5, 2025

cmsbuild added the tests-started label Nov 5, 2025

cmsbuild added tests-approved and removed tests-started labels Nov 5, 2025

smuzaffar changed the title ~~No need to explicitly delete the pre-existsing histogram for ROOT 6.39~~ No need to explicitly delete the pre-existsing histogram for ROOT >= 6.38 Nov 6, 2025

cmsbuild added alca-approved fully-signed and removed alca-pending pending-signatures labels Nov 8, 2025

cmsbuild added orp-approved and removed orp-pending labels Nov 8, 2025

cmsbuild merged commit d425381 into cms-sw:master Nov 8, 2025
10 checks passed

akritkbehera mentioned this pull request Nov 10, 2025

[ROOT] Updated root to tip of branch master cms-sw/cmsdist#10187

Merged

cmsbuild mentioned this pull request Nov 10, 2025

Need to add TracksHost::Implementation to classes_def.xml #49360

Merged

No need to explicitly delete the pre-existsing histogram for ROOT >= 6.38 #49319

No need to explicitly delete the pre-existsing histogram for ROOT >= 6.38 #49319

Uh oh!

Conversation

smuzaffar commented Nov 5, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cmsbuild commented Nov 5, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cmsbuild commented Nov 5, 2025

Uh oh!

cmsbuild commented Nov 5, 2025

Uh oh!

smuzaffar commented Nov 5, 2025

Uh oh!

perrotta Nov 5, 2025

Choose a reason for hiding this comment

Uh oh!

smuzaffar Nov 5, 2025

Choose a reason for hiding this comment

Uh oh!

cmsbuild commented Nov 5, 2025

Uh oh!

cmsbuild commented Nov 5, 2025

Uh oh!

smuzaffar commented Nov 5, 2025

Uh oh!

cmsbuild commented Nov 5, 2025

Comparison Summary

Uh oh!

smuzaffar commented Nov 7, 2025

Uh oh!

perrotta commented Nov 7, 2025

Uh oh!

perrotta commented Nov 8, 2025

Uh oh!

cmsbuild commented Nov 8, 2025

Uh oh!

mandrenguyen commented Nov 8, 2025

Uh oh!

Uh oh!

iarspider commented Nov 10, 2025

Uh oh!

smuzaffar commented Nov 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

smuzaffar commented Nov 5, 2025 •

edited

Loading

cmsbuild commented Nov 5, 2025 •

edited

Loading

smuzaffar commented Nov 10, 2025 •

edited

Loading